Skip to content

[SC 9106] Include number of records in the overfit diagnosis test#334

Merged
AnilSorathiya merged 1 commit intomainfrom
anilsorathiya/sc-9106/include-number-of-records-in-overfit-diagnosis
Mar 19, 2025
Merged

[SC 9106] Include number of records in the overfit diagnosis test#334
AnilSorathiya merged 1 commit intomainfrom
anilsorathiya/sc-9106/include-number-of-records-in-overfit-diagnosis

Conversation

@AnilSorathiya
Copy link
Contributor

@AnilSorathiya AnilSorathiya commented Mar 11, 2025

Internal Notes for Reviewers

Add number of test and training records columns in the result table

image

@AnilSorathiya AnilSorathiya added the internal Not to be externalized in the release notes label Mar 11, 2025
@AnilSorathiya AnilSorathiya changed the title [SC 9106] Include number of records in overfit diagnosis test [SC 9106] Include number of records in the overfit diagnosis test Mar 11, 2025
@github-actions
Copy link
Contributor

PR Summary

This pull request enhances the OverfitDiagnosis functionality by adding the capability to track the number of test records. Previously, the function only tracked the number of training records. The changes include:

  • Addition of a new column test records to store the number of test records in the results.
  • Update to the output dictionary to include Number of Test Records alongside Number of Training Records.

These changes improve the diagnostic capabilities by providing a more comprehensive view of the dataset used in model validation.

Test Suggestions

  • Verify that the OverfitDiagnosis function correctly includes the Number of Test Records in its output.
  • Test the function with datasets of varying sizes to ensure that the test records count is accurate.
  • Check that the addition of test records does not affect the existing functionality of the OverfitDiagnosis function.
  • Ensure that the output format remains consistent with previous versions, aside from the new additions.

@AnilSorathiya AnilSorathiya requested a review from juanmleng March 11, 2025 13:05
Copy link
Contributor

@juanmleng juanmleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cachafla
Copy link
Contributor

^ ready to merge?

@AnilSorathiya AnilSorathiya merged commit 037ea72 into main Mar 19, 2025
9 checks passed
@AnilSorathiya
Copy link
Contributor Author

^ ready to merge?

yes. merged. thanks

@johnwalz97 johnwalz97 deleted the anilsorathiya/sc-9106/include-number-of-records-in-overfit-diagnosis branch August 20, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants